Open
Conversation
|
|
blse-odoo
reviewed
Feb 16, 2026
blse-odoo
left a comment
blse-odoo
left a comment
There was a problem hiding this comment.
It is a good start, congrats on your first PR!
I noticed you used very short commit messages, did you have a look at the git guidelines? Just to get familiar with the process, I think would be better to try to follow them a bit
- Deleting module 'chapter1_firstmodule' - Moving module 'chapter2_estate' to 'estate' as it will be used through all chapters
Fixing `estate_property_action` id error on module installation due to wrong order in `__manifest__.py`
blse-odoo
reviewed
Feb 17, 2026
Add/customize the following wiews : - property list - property search - property form
'active' and 'garden_orientation' fields were not creating in the DB due to comma at end of line
Implementing new property related models : - Property type: M2O - Property tags: M2M - Property offers: O2M
blse-odoo
reviewed
Feb 17, 2026
| ], | ||
| copy=False, | ||
| ) | ||
| partener_id = fields.Many2one("res.partner", string="Buyer", required=True) |
There was a problem hiding this comment.
Just a typo here: partener_id should be partner_id ;)
| name = fields.Char(required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Date(copy=False, default=date.today()+relativedelta(months=3)) |
There was a problem hiding this comment.
Could you check if this default value is 3 month after the record creation, or 3 month after the model is loaded on startup?
- Property total area auto computed - Best offer selection - Offer validity & date auto update - Property garden onchange pre-filling - `partener_id` typo fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, first commit here!